fisker Cheung

Results 1279 comments of fisker Cheung

One note, taged templates should not reported.

I started few month ago, but I can't remember the progress... https://github.com/fisker/eslint-plugin-unicorn/commits/no-useless-interpolation

How many will left if we remove `read-pkg-up`?

Run into the same problem again, turns out [`handler.setPrototypeOf()`](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Proxy/Proxy/setPrototypeOf#return_value) [`handler.deleteProperty()`](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Proxy/Proxy/deleteProperty#return_value), [`handler.preventExtensions()`](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Proxy/Proxy/preventExtensions#return_value) need return `true` too. Didn't test, but [`handler.isExtensible()`](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Proxy/Proxy/isExtensible#return_value) also throws in some case.

The `Set` case should be safe, but we don't know if the object is a `Map`, I guess we'll have to turn auto-fix into a suggestion. Or maybe assume it's...

Is [import-style](https://github.com/sindresorhus/eslint-plugin-unicorn/blob/main/docs/rules/import-style.md) good enough?

I prefer the uppercase, and I try to make Prettier print uppercase years ago https://github.com/prettier/prettier/pull/7514, but I'm fine to add an option.

It's hard to check places that only allows `utf-8`, but `utf-8` works everywhere (I think), how about we switch from `utf8` to use `utf-8`? Mentioned this problem in original proposal,...

Forgot `Array#indexOf()`, seems we can't support it.