fisker Cheung
fisker Cheung
Feel free to kill it, it's known dangerous. https://github.com/prettier/prettier/pull/9736#discussion_r527916210
The originally version was for markdown, there might be difference with current one. https://github.com/prettier/prettier/pull/8496/files I also tried to move it back, didn't finish https://github.com/prettier/prettier/pull/13701
Overall, this is good improvement to to me. The following doesn't look great ```diff - const [idNode, initNode] = - node.type === AST_NODE_TYPES.VariableDeclarator - ? [node.id, node.init] - : [node.left,...
```diff - const { endAdornment, ...InputPropsWithoutEndAdornment } = - InputProps || {}; + const { endAdornment, ...InputPropsWithoutEndAdornment } = InputProps || + {}; ``` Please add this to tests when...
@g-cappai There are some cases not look very good, I haven't got time recently, can you take a look yourself? https://github.com/prettier/prettier-regression-testing/issues/419#issuecomment-1749851305
```diff - const [showPublishLibraryDialog, setShowPublishLibraryDialog] = - useState(false); + const [showPublishLibraryDialog, setShowPublishLibraryDialog] = useState( + false, + ); ``` Maybe ```js const [ showPublishLibraryDialog, setShowPublishLibraryDialog, ] = useState(false); ``` ?
```diff - const { - width = 512, - height = width, - mirror, - style, - ...rest - } = typeof opts === "number" ? ({ width: opts }...
```diff - const { - bins, - timeUnits, - aggregate, - groupby, - encoding: encodingWithoutContinuousAxis - } = extractTransformsFromEncoding(filteredEncoding, config); + const {bins, timeUnits, aggregate, groupby, encoding: encodingWithoutContinuousAxis} = extractTransformsFromEncoding(...
I think we need to find out how to distinguish the cases I mentioned in https://github.com/prettier/prettier/pull/15447#issuecomment-1763030855 https://github.com/prettier/prettier/pull/15447#issuecomment-1763031233 https://github.com/prettier/prettier/pull/15447#issuecomment-1763032678 and others you changed before.
@seiyab Does https://github.com/prettier/prettier/pull/15909/commits/be4b1c6d68b4b209d33a0cf893ba1b744d2708ed make sense to you ?