fisker Cheung

Results 1279 comments of fisker Cheung

What's your opinion on https://github.com/prettier/prettier/issues/11833

Since we have `--embedded-language-formatting=off`, we need add fallback in the generic print function. **Prettier pr-15087** [Playground link](https://deploy-preview-15087--prettier.netlify.app/playground/#N4Igxg9gdgLgprEAuEAeAzjAngGzgPgB0oACEgCzgEMATOAJxOBOLLJoEt0AHHKrJCQBmeAB4BuFqTYArAK6YOQrAFpIsBDEE8qYOCoBGcGAHc4CSazYHdAawDm9CHKg1B9ewYAUAFgAMADT+QX4AlJZQVgC+UmwUAIxMsXEkALZUHhxQgn6SkDgQ9IIm5BzwEXExxKgA9Ji4BCABIBDcMBzQ6MigGU4mAAoZCF0oVDgm-F3NBvR2xgDKVKlwADJZcMhCY+hw07Ngtgvculn2yDD0crsgO6kc55fX6Kd4AIpyEPCb29cy6KLzF5wd6fDZILY4HbNACOH3g-Sc3BGICo6BUUHMdBoTRAFyoHBwpwAwhBUulkCicDgcc8oPY8ABBGAXDgGOTwhhrDHfSHXcgwVI4ADqpXgOj082GZQ4ADcylgKWB0FMQDKrgBJVyaeZgegcNoM1zzbB4HlQkDcJw7IWzbgUy1wHb0GUbZpZJ0wBFUezk8E-ZrHehOin0jhkhg4y1ZGBCjg0GDkZAADkCIHocFhHHTXp9VDN1xgVAMsfjiaQACZmgo4AAVIsjCHmuCpIw0LErKh0uTeuAAMUK6WZpwpECEQhAUSiQA) ```sh --parser glimmer --embedded-language-formatting off ``` **Input:** ```hbs header { display: flex; justify-content:...

> is anything blocking this work? it's unclear from comments / labels / etc Sorry for the long delay, I was busy.

> We are already checking if first argument type is "Identifier" Damn, missed.. Sorry.

Looks better to me without this `padding` on cellphone. ![image](https://github.com/prettier/prettier/assets/172584/3e725f7c-cf9d-4cf6-9f59-bf0010aead37) Before: ![image](https://github.com/prettier/prettier/assets/172584/00c314a9-34d7-4d05-a4bf-2474cc88a02f) After: ![image](https://github.com/prettier/prettier/assets/172584/70f59c5a-b0ec-4c80-86fa-ccb48b6ae150)

I'm not familiar with the markdown spec, but will this break CommonMark?

@kachkaev mentioning you since you are involved in #3990

https://github.com/codecov/feedback/issues/265

Since v3 start failing, I'm going merge this, and not wait for https://github.com/codecov/feedback/issues/265