fisker Cheung
fisker Cheung
The second argument also little different https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/replace#specifying_a_string_as_the_replacement ```js '1_2_3'.split('_').join('$&') //=> '1$&2$&3' '1_2_3'.replaceAll('_', '$&') //=> '1_2_3' '1_2_3'.split('_').join('$$') //=> '1$$2$$3' '1_2_3'.replaceAll('_', '$$') //=> '1$2$3' ```
You need Node.js 20 to update snapshots https://github.com/sindresorhus/eslint-plugin-unicorn/blob/231529aee793251f30416b93dc3d5f9bfa27ee47/.github/workflows/main.yml#L44-L45
Personally, I like `--multiline-object=collapse`. 👍 from me.
@pauldraper https://github.com/prettier/prettier/pull/16163#pullrequestreview-1984476546
~FYI: There is a third-party implementation https://github.com/microsoft/parallel-prettier~ It's in the topic
@connor4312 Do you think we can add your implementation to our CLI?
Actually we plan to make api async , see https://github.com/prettier/prettier/issues/4459, so we need make CLI async anyway.
@connor4312 I start to make CLI async few days ago, happened the test part didn't get started, cherry-picked your commit :smile: https://github.com/fisker/prettier/pull/1091
I found it's hard to make tests pass, `describe` can't use async, you already changed to `test`, but `test` can't be nested..
@connor4312 #10804 #10841 #10852 ~(Not merged yet)~ Do you need something else before you start work on this?