fisker Cheung comments

Results 1279 comments of


                                            fisker Cheung

Upgrade to remark-parse@9+

Removed from v3 milestone, we'll continue work on it after v3 release.

Unnecessary escape

`-` always [sorted at last in CharacterClass](https://github.com/DmitrySoshnikov/regexp-tree/commit/091d4e9083abbc9f9573053d220c8a3db1fb3308) , should be able to remove escape

Don't look for a configuration file outside the project directory

https://github.com/prettier/prettier/blob/b5f39481aaebdeb17e88381eaede6e87aa03056b/.editorconfig#L1 https://github.com/prettier/prettier/blob/b5f39481aaebdeb17e88381eaede6e87aa03056b/.eslintrc.yml#L1

Don't look for a configuration file outside the project directory

Pass this https://github.com/prettier/prettier/blob/b1f4d95e3baaab9b195d05cc5dfdaa868fb19496/src/config/resolve-editorconfig.js#L8 as [`stopDir`](https://github.com/davidtheclark/cosmiconfig#stopdir) option should fix this.

Don't look for a configuration file outside the project directory

I'm going to postpone this, can't get it done before v3 release.

Don't look for a configuration file outside the project directory

We'll accept this.

TypeScript constructor assignment improvement.

Fixed by #14402

JS: Break lines before binary operators (fixes #3806)

I'm going to postpone this, since we haven't reached a consensus.

Rule proposal: `no-typeof-undefined`

I've sent #1966, we'll check all `typeof ANYTHING === 'undefined'` by default. When set `{checkGlobalVariables: false}`, the rule will ignore variables if it's not defined in file, including unresolved and...

Rule proposal: `no-typeof-undefined`

I don't really mind, I'll use `checkGlobalVariables: false` anyway. @sindresorhus your call.