fisker Cheung

Results 1279 comments of fisker Cheung

> I'm not sure if corejs({targets}) supports SemVer syntax with targets = {node:'semver'} https://github.com/sindresorhus/eslint-plugin-unicorn/pull/1717#discussion_r961621787

I mean I don't know if core-js accept `engines` if not, translate to `targets`, other user input `targets` pass directly to `core-js`.

Another rule rename idea, `prevent-abbreviations` should renamed as `no-abbreviations`.

Deprecate `prefer-node-protocol` , since it's adopted by `eslint-plugin-n` https://github.com/eslint-community/eslint-plugin-n/blob/master/docs/rules/prefer-node-protocol.md

Let's close for now.

Maybe we should split this into separate rules, to make rules easier to maintain. - `prefer-array-to-reversed` - `prefer-array-to-sorted` - `prefer-array-to-spliced` - `prefer-array-with`

Use `idsAsString.map(Number);`, it's allowed in `no-array-callback-reference`.

It's common to filter with `.filter(Boolean)`, if you want filter out `"0"` too, you may want try `.filter(element => Number(element) !== 0)`, it's more clear.

We only lowercase doctype when it's HTML5. Can you share an example that we break it?