fisker Cheung

Results 1279 comments of fisker Cheung

To fix this issue, we need find out what's the conflictting rule and extend it's fix range.

> then(f, g) is equivalent to catch(g).then(f) always Actually, no, they are not equivalent. ```js Promise.resolve() .then( () => {throw new Error}, () => console.error('error caught') ).catch(() => {}) ```...

Sorry, I didn't read carefully, please ignore my comment above.

I think I remember why I use `[]` now, it doesn't allow `false` at all, https://github.com/typescript-eslint/typescript-eslint/blob/958fecaef10a26792dc00e936e98cb19fd26d05f/packages/typescript-estree/src/parseSettings/getProjectConfigFiles.ts#L25-L33 I don't like `{project: undefined}`, because `{}` is the same(and I'm the author of...

And `getProjectConfigFiles` returns different result for `{project: null}` and `{project: []}`...

FYI: I have [`url-or-path`](https://github.com/fisker/url-or-path/) published myself, and I found check protocol not that useful, and [I removed recently](https://github.com/fisker/url-or-path/commit/cc97eb105d33c885049cefe680a3ca548305348d).

> You can use Atomics.notify() to let the worker thread tell the main thread when it's initialized. Yes, that's extracly what I did, https://github.com/fisker/make-synchronized/commit/a5bca6604dcf6a71f3f4e7a9de9daa183137bb3c But [an issue](https://github.com/fisker/make-synchronized/issues/17) was reported that...

[acorn](https://github.com/acornjs/acorn/commit/e708a22874739825a3ed87eb3b265eadb8d6b947) set `allowHashBang` to `ture` when using latest ecma version. [espree](https://github.com/eslint/espree/pull/556). meriyah also support it.