fisker Cheung

Results 1279 comments of fisker Cheung

Add file name is easy, hard to get line number.

Implemented https://github.com/nicolo-ribaudo/jest-light-runner/issues/27#issuecomment-1109838214 in my module, https://github.com/fisker/esm-utils/pull/294. :smile:

Finally figured why [this trick](https://github.com/nicolo-ribaudo/jest-light-runner/issues/27#issuecomment-1109838214) didn't [work](https://github.com/nicolo-ribaudo/jest-light-runner/pull/31), the error comes from [`import()` call in our setup file](https://github.com/prettier/prettier/blob/23f5ca2476975134c78a6706db4652b5aedc294f/tests/config/get-prettier.js#L7), that's before runner loading tests.

The next branch supports ESM now.

Updated Seems @sosukesuzuki already expressed similar opinion https://github.com/prettier/prettier/pull/13172#pullrequestreview-1050296694. I forgot about it. --- We format tagged templates with these names because people use libs provide them for certain functionality. I...

I'm going to close this since team members not agree to accept. We'll discuss how to improve embed template support in https://github.com/prettier/prettier/issues/5588 Sorry, @fregante

@sosukesuzuki Let's merge this into main?

Not release, just merge, seems unnecessary to have two branch for dev now, we won't make big changes for v3. But I'm fine to keep, just a question.