Jonathan Behrens
Jonathan Behrens
The `write_image` method also takes a `ColorType` value that indicates the meaning of the samples. The problem is that the buffer length is checked before confirming that the specified color...
If I'm understanding the quoted code correctly, Filament isn't using `683` as the luminous efficacy but rather `683 * efficiency`. Which means that if you want to have a final...
I think this can be closed?
There's some unreleased fixes for 1-bit TIFF files in https://github.com/image-rs/image-tiff/pull/252. However, at the moment the `image` crate bails regardless when it encounters one, because there isn't any logic yet to...
Would methods or trait impls returning `Result` be a good motivating example here?
I think we could derive Serialize/Deserialize for these types. Though, it would require placing the derive within a `cfg_attr` so it was only enabled when serde a serde feature was...
This is an interesting approach! I want to give it some more thought before committing, but it does seem clever to enable DynamicImage to be converted to a view of...
Another option is to checkout e2990d5b49536791cfaa2bc89db98a2eb6e1a923, the commit that was meant to be released, and publish that as 0.13.2
Thanks for this PR! I am in favor of adding 16-bit support here. One concern is that the `write_image` should not require that users pass aligned slices. If the color...
Looks good to me. Not quite sure why GitHub didn't rerun the CI tests when you pushed again