Jonathan Behrens comments

Results 621 comments of


                                            Jonathan Behrens

Static reader node replication

Last I recall query removal was being corrected because it didn't properly handle deletion of non-reader nodes. I'm not sure what the current status is

Creating a slice of uninit memory is unsound (equivalent to mem::uninitialized)

What is the status of this? Are these concerns purely hypothetical, or is there potentially unsoundness in the library?

[RFC] Splitting EthernetInterface into composable components

I also like that this proposal has the potential to enable smoltcp to be used for only part of a network stack. As best I can tell, this isn't really...

Color format

It decodes to RGB or RGBA. If you want to convert to a different order, just iterate over the output data pixel by pixel and permute the channels.

Color format

We'd also have to figure out exactly what supporting `cint` meant. I'm not convinced their interface matches what we'd need.

Yet another PR like #122

Yeah, the commands would be something like: ``` $ git add foo.rs bar.rs $ git commit --amend $ git push --force-with-lease ```

Add an option to decode to a premultiplied form

If you want premultiplied alpha, isn't the right approach to apply it yourself before saving the PNG?

Debug-mode arithmetic overflow in JPEG decoding (found by fuzzer)

Relevant line: https://github.com/image-rs/jpeg-decoder/blob/beb46c0dfd5e1de00e4f7fc72822bbc6e60d4c75/src/decoder/lossless.rs#L201

parse JFIF APP0 sections and expose Density with DensityUnits

This PR generally looks good to me, though I agree that it should probably either fully decode thumbnail images or just ignore them.

Change color_convert_line_cmyk so it gets auto vectorized

Could you elaborate a bit more on this change? I'd be hesitant to add platform specific unsafe SIMD intrinsics unless there was a substantial performance improvement, and no alternative way...