Jonathan Behrens
Jonathan Behrens
The `PngDecoder` struct was changed to returning `ImageResult` in 0.25.0 so that blocker mentioned in the linked issue has been resolved. Unfortunately, there's another problem. The `ImageDecoder` trait in the...
Thinking about it, the other thing we probably need to change is how the ICC profile, EXIF chunk, and text chunks are accessed. Right now they're public fields on the...
One puzzle will be how to handle `Encoder::with_info`. Currently it only takes an `Info` struct, so it wouldn't have access to the ICC or EXIF profile if those were switched...
I didn't completely follow that. Is the idea that we would make `Decoder::set_ignore_iccp_chunk` save the stream position of the ICC chunk, and then add a method on `Reader` to seek...
The `miniz_oxide` backend doesn't support window_bits. Regardless of what value you pass, it will always create zlib bitstreams with the header indicating window_bits=15. Before this PR, the `new_with_window_bits` methods were...
I haven't used it before, but seems like it is worth a try
Could you sketch out a bit more of what that might look like? In particular, what would be the type signature of the _Iterator::next()_ function equivalent on `Something` that would...
> it is currently not possible for an external crate to be both generic in GenericImage (or this new ContiguousImage) and have a specialized method that extends the trait at...
I think it is OK not to have first class support for weird memory layouts. Just providing conversion methods should be enough for most use cases (including for the author...
Ah, you were thinking of "enforcing layout" much more strongly than I was. I was just thinking that if someone chooses to implement the trait in a way that returns...