Jonathan Behrens

Results 621 comments of Jonathan Behrens

I think that `UnsupportedErrorKind::Color` is probably best. Though I've also been meaning to double check what the actual printed message from that looks like. I think I recall the output...

The code itself looks good to me, but TBH I'm not really sure what the implications of this change are

Thanks for putting this together! Seeing how much of the crate works with no_std (including `ImageBuffer`, `DynamicImage`, `imageops`, etc.) I do think this is worth doing. Figuring out how to...

> > Figuring out how to replace `std::io::Write/Read` is really the limiting factor for having encoding/decoding with no_std. I'm not sure there even _is_ a way to do so without...

I think looking at the QOI codec might give a false impression of the work involved in moving encoding/decoding over to no_std. Others are far more complicated. The TIFF and...

I'm in favor of including DDS in `image-extras`. I'll be spending some time this weekend trying to get that crate ready for a first release. Would be nice if we...

Just finished getting through the PR backlog on `image-extras`. Reviewing changes to decoders used by `image` tends to be a very slow process because I have to read over the...

It isn't specific to this PR, but we really shouldn't be generating fatal errors in response to corrupt auxiliary chunks. Opened #525 to track. > Just to inform you, I...

The indexed test image is 1 MB. We've already got some large images checked into the repository, but it would be better to avoid checking in more. Haven't had a...

Also, you can convert a DynamicImage to a specific ImageBuffer type by matching on the enum