Jonathan Behrens

Results 621 comments of Jonathan Behrens

Do we need to take the thread pool as an argument? I'm not super familiar with the low-level details of rayon, but it looks like they expose [a method to...

Depending on the format of the data you're trying to get [`Decoder::get_tag_u8_vec`](https://docs.rs/tiff/latest/tiff/decoder/struct.Decoder.html#method.get_tag_u8_vec) might be what you want? _Edit: though skimming that other thread it looks like the data isn't already...

I could also imagine an API analogous to our current handling of pixel data. For querying tags, there'd be a way to get the number of bytes and a way...

The `image-webp` crate [should already support](https://docs.rs/image-webp/latest/image_webp/struct.WebPDecoder.html#method.xmp_metadata) extracting XMP metadata.

Could you check if the issue happens with the latest commit on `main`? There's been a bunch of changes to TIFF decoding that we haven't released yet

Looked in more detail. The problem is that the file uses YCbCr encoding. The underlying `tiff` crate can extract the pixel data, but we lack support for converting it to...

For reference, the way that `ImageDecoder` is dyn-compatible despite consuming Self is this pair of required methods: ```rust trait ImageDecoder { fn read_image(self, buf: &mut [u8]) -> ImageResult where Self:...

Do we populate the correct CICP even if the PNG directly contains an cICP chunk? IIRC loading color spaces from files was still fully unimplemented

My initial reaction was that we might want to have an encoding analog of `ImageReader` rather than just a method on `IamgeFormat`, but maybe that's not necessary? As far as...

I'd be more inclined to add a `ImageReader::set_file_extension` method (potentially with a different name) that set the format via file extension, since that's what the `Format::Extension` variant refers to, not...