Robert Findley
Robert Findley
I agree this is a good and simple refactoring to apply. However we should fix AST comment handling (#20744) first -- something that we have on our radar for this...
It works for me. In your `go env` output, I see `GOEXPERIMENT=''`. Are you sure you set GOEXPERIMENT in your environment? I just did: ``` export GOEXPERIMENT=rangefunc nvim main.go ```...
> go: unknown GOEXPERIMENT rangefunc Hmm, do you have multiple versions of go installed? Is it possible that the go your neovim sees is not go 1.22?
Could you share gopls logs from a short session that demonstrates the problem? That would help us investigate why it isn't working in your session. https://github.com/golang/tools/blob/master/gopls/doc/troubleshooting.md#capture-logs
This is probably due to recompilation of std archives (which are cached following https://go.dev/cl/460635). Perhaps we should add a special case and build archives with `GOEXPERIMENT=loopvar` here: (https://cs.opensource.google/go/x/playground/+/master:Dockerfile;l=90;drc=6821b5629810defb1ea68149e090b5b86576d7ca) @bcmills can...
@fzipp that's a great point. In that case, I don't think we should bother making this work better for 1.21. It would increase the disk space required for every build,...
Unfortunately that reproducer did not reproduce for me: ``` [roam:65590]> go install golang.org/x/vuln/cmd/govulncheck@latest [roam:65590]> govulncheck ./... Scanning your code and 45 packages across 1 dependent module for known vulnerabilities... No...
Huh, I couldn't immediately reproduce this, which turned out to be because I was using the prerelease. I can reproduce with [email protected], but not with [email protected]. Could you please try...
Elsewhere in the codebase (e.g. documentHighlight) there is short-circuit logic when the cursor is in a composite literal. I think we need the same logic for signatureHelp: if you're inside...