Piotr Findeisen

Results 644 comments of Piotr Findeisen

`#[recursive]` is a good thing, but we could do better. in the IR, we could make OR a multi-child operation (not binary). This would naturally solve tree depth problem (just...

i am not saying we shouldn't do this (OTOH i believe the stack overflows on generates queries, and usually because long _associative_ operations. it's harder to generate otherwise) let's do...

BTW the fact that we needed to make get_type recursive that we can spend quite some time recalculating types. If an optimizer code calls expr.get_type, this can easily get quadratic...

After https://github.com/apache/datafusion/issues/9289, it would be good to recap what's tbd in this issue.

> The only downside I see is that the "state" is not going to be serialised if it has to be distributed in systems like ballista. That's because we don't...

I am not using ballista currently. I realized the plan serialization concern is easy to address if we separate simplify into phases: the Expr-constraint simplify (e.g. pruning args known to...

Thanks for this lint, i like it very much. Would it be possible to convert `#![deny(clippy::clone_on_ref_ptr)]` scattered across the code base into a single workspace-level definition?

- https://github.com/apache/datafusion/issues/17083 I think we can otherwise close this issue?

> While my experience here is regarding Postgres, I am sure this could be applicable to other connectors as well. This is PostgreSQL-specific and is caused by the way partitioned...

Once this is merged, the changes need to be backported to existing active 1.x.x branches.