Piotr Findeisen

Results 644 comments of Piotr Findeisen

> You would _generally_ probably want these retried if this was a one-off I think so > if you're seeing this happen with any regularity then you probably have a...

Change LGTM, but FYI, the build is failing.

Also related - https://github.com/trinodb/trino/issues/13273

per @martint 's https://github.com/trinodb/trino/pull/27364#issuecomment-3569169084 we're not currently willing to add `ILIKE` as a new syntax, so the functionality would be implemented as a function. i synced with @martint and the...

> I was also thinking about doing some more black-box testing: I think given any `min, max` you can always convert that into a RecordBatch with an array of the...

Some sqllogictests failed and this is expected. @adriangb can you please update them with ``` cargo test --test sqllogictests -- --complete ``` ?

> Some sqllogictests failed and this is expected. @adriangb can you please update them with > > ``` > cargo test --test sqllogictests -- --complete > ``` > You will...

> When I run it I get various errors along the lines of: > > ``` > Execution error: Error completing "string/string_view.slt": failed to rename file from test_files/string/init_data.slt.part.temp to test_files/string/./init_data.slt.part...

> (x) Release notes are required, with the following suggested text: > > ``` > ## Section > * Skip analysis of underlying queries for fresh materialized views. ({issue}`issuenumber`) >...

We have a test `io.trino.plugin.iceberg.TestIcebergMetastoreAccessOperations#testSelectFromMaterializedView`. We should add another test, with a fresh mv. Add it as a prep commit. Then the `Skip underlying query analysis if MV is fresh`...