Piotr Findeisen comments

Results 644 comments of


                                            Piotr Findeisen

Flaky `TestHiveAlluxioMetastore`

Can we perhaps remove the Alluxio integration?

Flaky `TestHiveAlluxioMetastore`

https://github.com/trinodb/trino/runs/7747794646?check_suite_focus=true

Test with GCS v2

updated per https://github.com/trinodb/trino/pull/12800#issuecomment-1211993336

Test with GCS v2

updated per https://github.com/trinodb/trino/pull/12800#issuecomment-1212208794 cc @alexjo2144

Add varchar to date conversion tests with signed year

(fixed commit ref in the commit msg; pasted wrong hash)

`NOT NULL` constraint not taken into account while adding a new column.

> The `NOT NULL` constraint set while adding the `city` column in the snipped below is not actually being added. This is a bug. Such can be allowed only if...

Re-enable comparison type match check in DomainTranslator

@sopel39 PTAL

Improve comparison predicate pushdown when varchar column cast to date

Marked draft because - pending clarification on whether any kind of predicate pushdown is allowed, see https://github.com/trinodb/trino/pull/13605#discussion_r942552662 - the current implementation isn't correct yet

Improve comparison predicate pushdown when varchar column cast to date

Ready for review now.

Improve comparison predicate pushdown when varchar column cast to date

Added a test in TestIcebergMetadataFileOperations that shows gains for Iceberg. Gains for JDBC connectors are "obvious".