Piotr Findeisen

Results 644 comments of Piotr Findeisen

there is a new conflict (perhaps due to https://github.com/apache/datafusion/pull/12196), let me rebase.

thank you @jayzhan211 for your review! would you mind taking another look?

thank you @jayzhan211 @crepererum @alamb for all your time spent reviewing this!

❤️ thank you for the (brave) merge, @crepererum !

> I recommend a config flag that makes it possible to convert `Utf8View`/`BinaryView` --> `Utf8` / `Binary` at the query output and I think this conversion should be done by...

> My rationale is that converting from Utf8View --> Utf8 is not free. it is not but transmitting non-compacted string views isn't free either. also, we're transitioning from a state...

I run into this recently. When constructing VALUES via API, the Alias expression can be thought to allow aliasing the VALUES columns, but this didn't work, alias got (silently) ignored....

> I think Sort would be an easier thing to remove / fix -- `Expr::Sort` as an expression is also bad as it means the signatures of `fn order_by(...)` are...

Besides fixing some problems (described in this issue + https://github.com/apache/datafusion/issues/1468#issuecomment-2308275476), separating "expression" and "named expression" could result in lower mental overhead involved when dealing with the code, given that in...