Piotr Findeisen comments

Results 644 comments of


                                            Piotr Findeisen

Infer data type from schema for `Values` and add struct coercion to `coalesce`

This is invalid query, but it succeeds ``` > CREATE TABLE t(a int) AS SELECT x FROM (VALUES (a)) t(x) WHERE false; 0 row(s) fetched. Elapsed 0.014 seconds. ``` It...

Infer data type from schema for `Values` and add struct coercion to `coalesce`

I am not convinced that that code we eventually **should have** will be natural evolution of the code here, so it's hard for me to judge whether this is a...

Infer data type from schema for `Values` and add struct coercion to `coalesce`

> I think as long as there is no regression we should move on and file the ticket for the remaining issue. Sorry for not following earlier, was on a...

Infer data type from schema for `Values` and add struct coercion to `coalesce`

> It seems the query is accidentally correct in before this change, because we don't know the result of the function when we build up Values plan. Values plan is...

Infer data type from schema for `Values` and add struct coercion to `coalesce`

thank you @alamb

Ability to build for all Scala versions

> * `allScalaVersions=true` lets Spark build for all Scala versions Forgive my ignorance. Does it affect the artifacts we build? Does it how we build them? Does it affect how...

Proposal: Create `dfdb`, a new CLI different than `datafusion-cli` with pre-built integrations

> One last thing I'll say — virtually all of the above features would be independent of the query engine being used, so there is a good argument to build...

Remove Sort expression (`Expr::Sort`)

Not ready for review. Just for FYI.

Remove Sort expression (`Expr::Sort`)

The build is all green (https://github.com/findepi/datafusion/actions/runs/10574858019)!

Remove Sort expression (`Expr::Sort`)

Rebased, should be ready for initial review pass. I split the change into couple commits, but bulk of it is still one big commit. Should i continue along this pattern?...