iceberg icon indicating copy to clipboard operation
iceberg copied to clipboard

Ability to build for all Scala versions

Open snazy opened this issue 1 year ago • 3 comments

Allows building for all Spark/Scala version combinations. Introduces new system properties to control the behavior:

  • allScalaVersions=true lets Spark build for all Scala versions
  • the previous property scalaVersion is now a version list via the scalaVersions property, provides backwards compatibility
  • the previous property defaultScalaVersion is now a version list via the defaultScalaVersions property, provides backwards compatibility

The defaults, via gradle.properties do not change.

Also...

  • Unify processing of the xyzVersions everywhere
  • Fix compilation bug in Flink 1.19 jmh code (was not built before)
  • Update release jobs/script
  • Remove "hack" for :iceberg-bom
  • Simplify and fix related usages of the build system properties

snazy avatar Jun 29 '24 09:06 snazy

  • allScalaVersions=true lets Spark build for all Scala versions

Forgive my ignorance. Does it affect the artifacts we build? Does it how we build them? Does it affect how we test them?

findepi avatar Jul 01 '24 10:07 findepi

  • allScalaVersions=true lets Spark build for all Scala versions

Forgive my ignorance. Does it affect the artifacts we build? Does it how we build them? Does it affect how we test them?

There is no change in how things are built or tested.

snazy avatar Jul 01 '24 10:07 snazy

@RussellSpitzer you have time to review?

snazy avatar Aug 02 '24 07:08 snazy

This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the [email protected] list. Thank you for your contributions.

github-actions[bot] avatar Nov 08 '24 00:11 github-actions[bot]

This pull request has been closed due to lack of activity. This is not a judgement on the merit of the PR in any way. It is just a way of keeping the PR queue manageable. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.

github-actions[bot] avatar Nov 15 '24 00:11 github-actions[bot]