Mourits de Beer

Results 150 comments of Mourits de Beer

I think `requested_attributes` should be filtering correctly. I just tested with `requested_predicates`, after adding some debug logs. From the code, all of the names in `requested_predicates` or `requested_attributes` are added...

I've opened a draft PR to show what I've tried so far (only for the AnonCreds section, not Indy yet). As mentioned, the WQL filtering is working opposite to how...

Setting to draft as merging this to main will potentially break deployments that are pointing to use main as opposed to 1.7.2. We'd probably want a stable version release and/or...

FWIW, I don't think any of the updates had breaking changes. But if there are no tests, only way to know is try fire up this branch locally and see...

@esune will do! The main blocker for me was not having tests to know if the dependency upgrades have broken anything. I remember when I made this, reviewed the changelogs...

@WadeBarnes can those tests be written in a yaml file for an automated GitHub workflow? If it's simple steps, GPT can translate it in no time.

What, how? Surely any manual steps can be automated. Because how is a codebase maintainable without automated tests? I'd happily write the workflow if I knew anything about the functionality...

@esune @WadeBarnes I've rebased this PR, with latest dependency upgrades (incl for indy_vdr) The reason that previously `No matching distribution found for aiohttp-jinja2~=1.5.1`, is because the base image being used...

Just a note: once this is merged, there is a Ruff lint category that can be selected: "UP". It helps to automatically upgrade python syntax to abide by a target...

> [@swcurran](https://github.com/swcurran) [@jamshale](https://github.com/jamshale) [@ff137](https://github.com/ff137) I may need som insight on [these lines](https://github.com/openwallet-foundation/acapy/blob/a9675114c34bdff26a8c8b2bef14cf12879cecd0/acapy_agent/multitenant/admin/routes.py#L593-L598): I don;t think they make sense for this route, but don't fully understand why the check was added....