Mourits de Beer

Results 150 comments of Mourits de Beer

I think it's ready for review / good to merge. We're using it on our fork. Essentially deprecates the string `count` and `start` params, and allows passing new `limit` and...

I'll take a swing at reducing the duplication

Oh shucks, I remember why I didn't deduplicate by inheriting from the PaginatedQuerySchema earlier. It's so that there's still backward compatibility, so that limit/offset is not loaded with default values,...

I'm hoping this one can be merged sometime soon.

PS: We wrote this lil async lock function that uses Redis / Valkey: https://github.com/didx-xyz/acapy/blob/1.3.1-20250702/acapy_agent/utils/async_lock.py Originally wrote that to solve the cred-rev concurrency issue, but it's no longer needed for that....

I agree that it's confusing. Might be a mistake, but I'm not sure. What's particularly confusing to me is that the [DID Exchange protocol roles](https://github.com/decentralized-identity/aries-rfcs/tree/main/features/0023-did-exchange#roles) should actually be "requester" or...

@swcurran I found the rfc23/rfc160 mismatch is in the ConnRecord init constructor, where it overrides `their_role` to use the rfc160 version. Change was last applied here, where stored values use...

Sample of a cred-ex record that failed, but remains in state done: ``` { "results": [ { "cred_ex_record": { "state": "done", "created_at": "2025-07-30T11:22:23.525604Z", "updated_at": "2025-07-30T11:22:28.990892Z", "trace": false, "cred_ex_id": "3a7033e4-fe7d-4b68-814d-fbd785d94822", "connection_id":...

The error message is telling you that the name `adarshnb-19.github.io:verifier` is invalid because it contains 3 different characters that are disallowed: `- . :` Why they are disallowed, and whether...

Can confirm that predicate / restrictions are not applied for the "matching credentials" It looks like the intention was there, to add restrictions to a base tag filter: ```py tag_filter...