Mourits de Beer

Results 150 comments of Mourits de Beer

Good news! Managed to successfully test the changes locally 🚀 after copying `target/release/libaries_askar.so` to `wrappers/python/aries_askar` 🚚 Happy to confirm that all the ACA-Py tests pass using this branch's changes ✅...

I think I'm gonna try add the ordering options for fetching all records -- not just for scanning. Makes sense imo to include it all in one PR

I've expanded ordering options to the `fetch_all` method as well. I can confirm python wrapper works with changes (ACA-Py tests pass using this build). JavaScript wrapper still has some tests...

@andrewwhitehead Please let me know if you've had moment to review, if there are any additional steps necessary here. Maybe changing default behavior, or implementing some specific tests. ACA-Py tests...

I realise I don't know enough about how the multi-architecture wheels are built, to replace things properly with poetry

@jamshale it's still in progress (I can't reopen it) -- still need to make a PR for connection / cred ex / presentation records. And adding support for ordering in...

Potential endpoints that may need pagination as well: - listing created rev regs, in the revocation API - listing transaction records, in the endorse_transaction API - listing mediation requests, in...

I've discovered a bug with pagination + additional post-filter query parameters. e.g. for fetching connection records, specifying limit=1 and alias="some alias", then it will return 0 records, despite that alias...

This impacts: - fetching v1 or v2 **credential** or **presentation** exchange records, with query params: `connection_id`, `role`, `state` - fetching connection records with: `alias`, `state`, `their_role`, `connection_protocol` These are all...

Agreed. It's of course highly inefficient -- loading each record result as json and post filtering on fields (edit: I see the json deserialization is necessary either way, nvm). I'll...