Mourits de Beer
Mourits de Beer
Btw, tracing the blame shows the logic was copied from the very first, original implementation here: https://github.com/openwallet-foundation/acapy/blame/2fda2a418a5b5b406ff6c7477dc1f4b3c65f8fb4/aries_cloudagent/multitenant/admin/routes.py#L183 So it's just been untouched since that very first implementation 5 years ago....
Apologies - I thought the logging changes were already contributed to main, but it was just running in our fork. It's essentially in `acapy_agent.messaging.models.base_record.py::emit_event`, we added: ```py async def emit_event(self,...
@swcurran Added more context to the above - I recall it was discussed in one of the meetings. The `forward_route` warnings can probably be suppressed - not sure how informative...
Marking ready for review just to see integration test results
@jamshale Hmm, I got the same error in the integration run: https://github.com/hyperledger/aries-cloudagent-python/actions/runs/10451102652/job/28936801431 even after committing all the libraries_askar.* files (in the `wrappers/python/aries_askar` dir) At first I couldn't run the PR...
For interest, the following commit shows the end-to-end tests that asserts unique records are returned across pages, when scanning with limit/offset: https://github.com/didx-xyz/aries-cloudapi-python/pull/989/commits/00c3f0f0369481d20a00da997ba56cb632887ee1 Those tests had to be commented out because...
@jamshale I managed to get integration tests passing - using an aries_askar TestPyPI package 👀 https://github.com/hyperledger/aries-cloudagent-python/pull/3173/commits/90cd53cc3f736ffc85128975ffca4f8484950b75 Last couple commits here show how I uploaded to TestPyPI: https://github.com/ff137/aries-askar/pull/1
Essentially just needs an official askar release (currently using my test-pypi package / fork of askar). And some minor rebasing. We're also using this in our fork for a few...
When the new askar version is pulled in, I'll wrap this one up.
> * Yes, The count/start endpoints should be renamed limit/offset. Cool, I can implement the same limit/offset pagination query params for these 3 endpoints, as for the other endpoints. >...