Fabien Potencier comments

Results 517 comments of


                                            Fabien Potencier

PHP Notice: Undefined index when using a {% for in %} tag on an undefined variable which is shadowed in the loop

@csnover Can you open a PR? That would make review easier I suppose.

Errors thrown for an invalid parent don't report their file and line as the Twig template

@stof Would you like to submit a PR?

Anchors to Symfony "Twig reference" documentation are not working

I've fixed the first issue for now. For forms, I have a global strategy right now but that does not work well, I think I need to hardcode the anchor...

Anchors to Symfony "Twig reference" documentation are not working

Should be fixed now.

Precedence of ?? operator

Let's fix the precedence. Anyone up for a PR (and some additional tests)?

Serious performance issues when including optional templates

If the logic is different, I would only optimize Twig 3.

[Mailer] Sending Messages Async should not be default behavior

Updating the docs would be nice indeed.

[Mailer] Sending Messages Async should not be default behavior

I've transferred this issue to the docs repo. Is anyone willing to work on a doc fix?

[Mailer] google-mailer DSN configuration not valid anymore

@jeremyjaouen Can you submit a PR to update the docs?

Replace annotations with attributes in code examples

I would use PHP attributes everywhere.