Fabien Potencier

Results 517 comments of Fabien Potencier

This is a read only, can you move this PR to the main Twig repository? Thank you.

Instead of adding another option, it would be better to understand why the `composer run` one didn't work for you.

Can you show me the output of `composer show`, because I'm not able to reproduce it here with the following deps: ``` monolog/monolog 1.21.0 Sends your logs to files, sockets,...

What if you run `composer up` to get the same versions as mine?

I don't really understand how that's possible. Can you add `print get_class($resolver)."\n";` after line 55 in vendor/symfony/http-kernel/Controller/ArgumentResolver.php and tell me what it outputs?

Can you send me a zip of the project (fabien ... symfony.com)? you should have `Silex\AppArgumentValueResolver` listed here, but for some reasons you don't.

Does it make a difference? We are already excluding the "bigger" files/directories: ``` /doc/** export-ignore /extra/** export-ignore /tests export-ignore /phpunit.xml.dist export-ignore ``` If you want to filter more, I suppose...

So, can you tell me which files should be excluded on top of what we already excluded? We are already removing doc and tests files for instance.

I would review a PR implementing this new behavior. But if we want to be "simple" to implement, it might mean bumping the min PHP version to 8.0 (7.2 right...