Fabien Potencier comments

Results 517 comments of


                                            Fabien Potencier

[Feature] Optional chaining operator

Implementation will tell us.

[Feature] Optional chaining operator

Indeed stof. But again, let’s talk about implementation in a PR

Support lexing numbers with underscores and decimals with no leading zero

Looks like it breaks some tests.

Added support for foo.some_thing === foo.someThing

@tucksaun @jpauli Can you have a look at the C part of this PR?

Added support for foo.some_thing === foo.someThing

This PR was auto-closed because I've removed the master branch and this PR was based on master. I cannot reopen it unfortunately.

Added support for foo.some_thing === foo.someThing

Changing the base branch to 2.x worked :)

Added support for foo.some_thing === foo.someThing

This one never moved forward as we did not get feedback on the C implementation. I propose to rebase it on 2.x where we don't have the C extension.

If statement with nothing set inside throws error

Anyone willing to work on a fix?

[Messenger] Unable to register extension "Twig\Extension\SandboxExtension" as extensions have already been initialized

Can't you mutate the sandbox via a call like the following? ```php $this->twig->getExtension(SandboxExtension::class)->setSecurityPolicy($policy); ```

Avoid usage of global functions

All functions are prefixed with `twig_`, so there should be no conflicts. In any case, that would be a BC break.