Fabien Potencier comments

Results 226 comments of


Fabien Potencier

[Translation] Add icu message support for the lokalise provider

@welcoMattic Can you have a look at the latest comment from @DanielBadura?

[Console] A getter function to returns only given input options

@fahamjv Any news here?

[Console] A getter function to returns only given input options

I think we would first need a use case or an explanation about why this is useful.

[Notifier] Update for V3 Engagespot API

@danut007ro Can you have a look at this change?

[Mailer] Delivery fails but actual SMTP response is not reported

Just tried the reproducer, but that does not work for me, I get: `Expected response code "250" but got code "550", with message "550-5.7.0 Mail relay denied [2a01:e34:ee66:4390:8210:a0ac:868f:4c56]. Invalid`

[Mailer] Delivery fails but actual SMTP response is not reported

I don't have an Azure account. I'm willing to help fix this one but I cannot do anything without a reproducer.

3 forks() just to get column widths and row height

Do you want to work on a PR? You should target version 6.2, where we support PHP 8.1+.

3 forks() just to get column widths and row height

Yes, a PR on 6.2 can only support PHP 8.1+.

[ MIME ] file mime/Header/ParameterizedHeader.php

The value must be a string. I don't see how your "workaround" can work to be honest.

Provide a default non-empty label on empty options to validate HTML5

Not sure about this change, but that would be for 6.2.