Eugene Kliuchnikov comments

Results 156 comments of


                                            Eugene Kliuchnikov

Set PKGCONFIG_TARGET_LIBS/INCLUDES for libjxl_cms.pc

I believe it is better to move this piece to `lib/CMakeLists.txt` and remove copy in `lib/jxl.cmake`, so that all `lib/` artifacts are affected.

Apple Silicon macOS build of djxl crashes on metadata-only decode

Will take a look soon.

WASM _jxlDecompress hangs browser

Will check soon.

reduce libjxl_dec binary size

Let's just rename files. That will be less surprising for future developers... I'll prepare a PR

OSS Fuzz Issue 64982: graphicsmagick:coder_JXL_fuzzer: Ill in jxl::Abort

This one is easy: internal check detects that too large piece of memory is about to be allocated. I believe API frontend checks that decoded image is not too large......

OSS Fuzz Issue 64982: graphicsmagick:coder_JXL_fuzzer: Ill in jxl::Abort

Well, since embedder does not pass compiler definition `FUZZING_BUILD_MODE_UNSAFE_FOR_PRODUCTION` it is not so easy to limit image size. Still we have plans to propagate allocation error to API level (instead...

OSS Fuzz Issue 64982: graphicsmagick:coder_JXL_fuzzer: Ill in jxl::Abort

Exactly, reacting to memory manager answer is what I meant by "plans". A quick and dirty fix for fuzzer is to add `FUZZING_BUILD_MODE_UNSAFE_FOR_PRODUCTION` compilation defenition when compiling for oss-fuzz and...

TNS_MAX_ORDER is object type and short/long window dependent

For short window it is capped with 7 indeed (search for `order_bits = 3` and `tns_order = min(tns->order[w][f], TNS_MAX_ORDER)`. For long window it is capped with 20, but again it...

TNS_MAX_ORDER is object type and short/long window dependent

@atimmernans it would be nice if you provide some quotes, to be sure we have coded it right. Currently I do not have access to spec to check it myself.

Different library versions in cmake and autotools builds

Hi. Sorry I've been offline for ~3 weeks. Will take a look soon.