Eugene Kliuchnikov

Results 156 comments of Eugene Kliuchnikov

Not possible. I've raised again the question of adding skcms github mirror.

Was that `sid` a `bookworm`? Can't repro on 0.7rc with Linux / x86_64 / gcc-12

Builds of 0.7 (not `rc`) were (maybe) successful: https://buildd.debian.org/status/logs.php?pkg=jpeg-xl&arch=amd64

@mo271 @sboukortt how do we proceed with this PR?

Let's instead rewrite condition to something like `y0_ >= 0 || y + y0_ = 0`.

Hi. Sorry to bother, but `y >= 0 && y0_ + y >= y0_` is not the same as `y0_ >= 0 || y + y0_ = y0_` is `true`...

Overall, second expression (`static_cast(y) + y0_ >= 0`) is more readable, since we overcome undesired "promotion" and show our desire to check that accessed row index is not negative. Additionally...

Extra check won't hurt, but I believe it is done inside `(Const)Row` already (see `VoidRow`).