Eugene Kliuchnikov comments

Results 156 comments of


                                            Eugene Kliuchnikov

Warnings on Windows with MSYS2 + mingw-w64

Will look into those soon.

(A|M)SAN build is very slow in CI

It seems that most files are compiled with "-O2".

error: there are no arguments to ‘Abs’ that depend on a template parameter, so a declaration of ‘Abs’ must be available [-fpermissive]

Going to add SVE to build matrix, so such problems would be caught timely.

error: there are no arguments to ‘Abs’ that depend on a template parameter, so a declaration of ‘Abs’ must be available [-fpermissive]

WARNING: even if it compiles, it likely won't work on SVE; perhaps going to disable SVE target by default.

Build fails with clang

It seems that (tools/) binaries does not see libraries. Will check in docker soon.

Macro Based Definitions For Public Facing API

We have used similar approach in brotli... And it seems that no-one has actually used those enums. I believe, we should rather look into the neutral ground, e.g. WebIDL. We...

Macro Based Definitions For Public Facing API

That was one thing I have been worrying about. Perhaps it will be better to write some AST transformer to convert c++ header to a different representation....

Removed warnings under Visual Studio (Windows)

Please use static_cast

brotli linking issues on macOS

Reworking brotli linkage. Will test on osx after that. thanks for the report.

explain tags for branch-off points

Let's do that differently. "describe" should say what we are looking at. Starting from 0.8 we will add a "descriptive" tag that refers to the next version we are planning...