libjxl Set PKGCONFIG_TARGET_LIBS/INCLUDES for libjxl

Without this, the .pc file ends up with those variables empty, breaking the build in hilarious ways as the empty -L / -I eat up the next argument.

This section is straight up copied from the two sibling .cmake files.

Oct 24 '23 00:10 BtbN

Thanks!

Oct 24 '23 07:10 mo271

Please add yourself to the AUTHORS file (I can also do it for you, if that is more convenient...)

Oct 24 '23 09:10 mo271

Thanks for attempting to fix the AUTHORS check! They still fail, because a different name/email address are used in the commits, see here:

https://github.com/libjxl/libjxl/commit/2b680c3a7c2b05db2e322a2900beb226b272d866.patch https://github.com/libjxl/libjxl/commit/0fedc58f36c1e09b55c644d7c85354e135727fc2.patch

Oct 24 '23 10:10 mo271

Should be fixed now, hopefully. Is it preferred to have the update of AUTHORS in a separate commit like this, or should I squash it into the first one?

Oct 24 '23 10:10 BtbN

I believe it is better to move this piece to lib/CMakeLists.txt and remove copy in lib/jxl.cmake, so that all lib/ artifacts are affected.

Oct 26 '23 08:10 eustas

Set PKGCONFIG_TARGET_LIBS/INCLUDES for libjxl_cms.pc