Eugene Kliuchnikov
Eugene Kliuchnikov
Hi, Dirk. Thanks for the PR. Currently codespaces are not enabled on this repo / org. Our team will discuss soon that topic. On the parallel track - I'm preparing...
`_export.h` depends on system, that is why I propose not to include it into sources archive. `version.h` is system-independent; it provides only 3 integers, so I believe we can include...
Idea: pull version info into a separate properties file to make build systems equal and depend on the same source. See e.g.: https://github.com/knik0/faad2/blob/master/properties.json
It depends on compiler: https://github.com/Kitware/CMake/blob/master/Modules/GenerateExportHeader.cmake Not saying it is impossible, but making it right would be difficult.
Will take a look soon
This refers to the following change: ``` - all_encodings.push_back( - {jxl::ColorSpace::kXYB, jxl::WhitePoint::kD65, jxl::Primaries::kCustom, - jxl::TransferFunction::kUnknown, jxl::RenderingIntent::kPerceptual}); + // TODO(firsching): understand why XYB does not work together with icc_dst. ```
Hello, Julien. Those "optional" args are intentionally accessed via `opt_xxx_id`, and initial value for it is `-1`. So, cleaner solution here would be not "if-def", but extra check that `opt_jpeg_quality_id...
To land this we need to: - fix move-in-return-statement - remove "gcc8" required workflow and add "gcc-8" after PR is landed
Will fix `CoeffOrderOffset` soon. This works with modern compilers, but alas, we have to support all kinds of nonsense...
Hello. It is still reproducible after #2987?