Esteve Fernandez

Results 331 comments of Esteve Fernandez

@nnmm I see you're submitting fixes for Windows, do you want to wait until this PR is complete before releasing? I'm fine with it being finished after the release.

> How have other client libraries such as rclpy worked around this? I can't speak for other client libraries, but definitely can for rclpy. rclpy hasn't worked around this issue,...

@i-am-chauhan thanks! This is great, however I'd prefer not to use `thread::sleep` in the library (for examples that should be fine). The way `rclcpp` solves this is by using guard...

Adding a signal handler for every context seems tricky and a source of problems (what if we have more than one context, will all of them handle the exit signal?)....

The `ctrlc` crate uses a form of global state, it has an static atomic that just makes sure that `set_handler` is only called once: https://github.com/Detegr/rust-ctrlc/blob/master/src/lib.rs#L60= And then `init_os_handler` also uses...

@DS3a to understand better how time is handled in ROS2, you can also have a look at https://design.ros2.org/articles/clock_and_time.html Regarding types, using `std::time::Duration` for example, might be possible to use, but...

@DS3a I suggest you start implementing support for clocks as you think is appropriate and then we can provide you with feedback, I'm really not a fan micromanaging contributions, it...

@DS3a could you submit a PR against `ros2-rust`? Even if it's a draft. It'll be easier for us to check the differences and to provide feedback. Thanks!

@DS3a also, before you submit the PR, I'd advice you rename the branch where you're making the changes. Right now your changes are in the `main` branch of your fork,...

> okay... gimme a sec Thanks :slightly_smiling_face: