Esteve Fernandez
Esteve Fernandez
@xmfcx thanks for the thorough review. After doing investigations, I think this is caused by a mismatched between: https://github.com/autowarefoundation/autoware.universe/blob/a3e776d4ee9105ce9c1349fd1ebbaba011f9614b/planning/autoware_behavior_velocity_planner/src/planner_manager.cpp#L52-L56 and, for example: https://github.com/autowarefoundation/autoware.universe/blob/a3e776d4ee9105ce9c1349fd1ebbaba011f9614b/planning/behavior_velocity_dynamic_obstacle_stop_module/src/manager.cpp#L73-L76 I'm going to update these files so...
I'm still debugging this, I prefixed code in behavior_velocity_planner_common, but it still does not work.
@xmfcx this is now ready for review, I've run the planning demo and it works. Also, all the plugins are loaded. The issue was in: https://github.com/autowarefoundation/autoware.universe/blob/578d135db30f875ef6c515b2870899981ad11a17/planning/behavior_velocity_crosswalk_module/CMakeLists.txt#L6 Plugins couldn't find the...
@xmfcx thanks, I've pushed the fix in f8b4cb6f37fd20084b55310eb56cc2e15f485b52
@xmfcx thanks for your feedback and the patience 🙂
@christophebedard was there anything left to do in #148 ? Or is it a matter of getting more feedback from @dirk-thomas ? Looks to me that your PR already achieves...
@christophebedard thanks for the info. Given that `vcstool` is such a fundamental tool for the entire ROS ecosystem, perhaps it'd make sense to move the repository to the @ros organization,...
@christophebedard I've created https://github.com/dirk-thomas/vcstool/issues/242, but if we don't get a response, I'll move the discussion to Discourse
@christophebedard I opened #242 a long time ago, but didn't get a response from @dirk-thomas . Given that you showed interest in helping maintain `vcstool`, it'd be good to move...
@kydos @JEnoch @Mallets can you assign this to me? I don't have perms. Thanks