Esteve Fernandez

Results 331 comments of Esteve Fernandez

build(behavior_velocity_template_module): prefix package and namespace with autoware_

@xmfcx I don't know what happened, but the changes for static_centerline_generator got mixed in. I've reverted them.

build(behavior_velocity_template_module): prefix package and namespace with autoware_

@xmfcx done, this branch had conflicts after https://github.com/autowarefoundation/autoware.universe/pull/6693 was merged

build(behavior_velocity_template_module): prefix package and namespace with autoware_

@xmfcx @danielsanchezaran @takayuki5168 thank you all for your reviews 🙂

build(behavior_path_external_request_lane_change_module): prefix package and namespace with autoware_

@xmfcx this is now ready for review again.

build(behavior_path_external_request_lane_change_module): prefix package and namespace with autoware_

@xmfcx I've applied your changes, could you have another look when you have a moment? Thanks.

build(behavior_velocity_planner): prefix package and namespace with autoware_

@maxime-clem fixed in https://github.com/autowarefoundation/autoware.universe/pull/6693/commits/8a08e4b136b368e3bbeefae84c50cca4338d0154, thanks for spotting it.

build(behavior_velocity_planner): prefix package and namespace with autoware_

@xmfcx thanks for approving this PR. GitHub requires a code owner approval so this could be merged, can you merge it anyway?

build(behavior_velocity_planner): prefix package and namespace with autoware_

@xmfcx I've applied your changes, thanks. Can you approve this PR? Thanks.

build(behavior_velocity_planner): prefix package and namespace with autoware_

@xmfcx nice catch! I've applied this change as well. Thanks.

build(behavior_velocity_planner): prefix package and namespace with autoware_

@xmfcx thanks for the thorough review, I'm looking into these issues. I'm moving this PR back to draft as it needs more changes.