Esteban Kuber
Esteban Kuber
> seems it still has problems? I think there's another `Vec::sort()` that needs to be `Vec::sort_by_key(|s| s.as_str())` in a different message :(
@bors r=wesleywiser
@bors r=wesleywiser
I believe I've addressed most of the comments (and have collapsed conversations to make way for new ones). Feel free to add additional comments for anything that might be missing....
> I have some reservations about the inequivalence between `let x = Foo { .. }` and `let x = Foo { ..Foo::default() }`, the implications of that inequivalence on...
I'm not quite sure how this PR affects https://github.com/rust-lang/rust/blob/75e9b19d78a601d07df4d8f19f72165026f32103/tests/debuginfo/lexical-scope-in-if-let.rs at all :(
> did that get merged or is this another case that needs to be covered? That got merged and covered [E0277 and E0308](https://github.com/rust-lang/rust/blob/01503d0c1e43a23de92ad1577cbdceb7afe47dab/tests/run-make/crate-loading/multiple-dep-versions.stderr), but not E0631. > I wonder if...
FYI, filed https://github.com/rust-lang/rust/issues/135589 to improve the error output from the compiler.
@epage (off the cuff) one thing that came up with `#[diagnostic]` is the need for it to be *very* permissive without causing errors: whenever you add a feature you would...