Erik Dubbelboer

Results 272 comments of Erik Dubbelboer

But that's no problem, cause in `net/http` not setting a status code means `200` and that's exactly what it is doing here: https://github.com/valyala/fasthttp/blob/d3aa5a15bb0131fe7e58e948cff8ee8ed748112e/fasthttpadaptor/adaptor.go#L98-L100 Or do you mean that you are...

Interesting use case. But in that case can't you just turn it around and do this? ```go if isBadRequest { Render(c, dialog.BadRequest()) c.Status(http.StatusBadRequest) } ```

I don't think it happens very often that someone using a http handler will still also want to run fasthttp code. That's why you're the first one to have this...

I'm afraid I don't have time to do that. But a pull request is of course always welcome!

Users using body streaming on the server side should use `Request.BodyStream()` to get an `io.Reader` and read as much as they need. It's not recommended to to call `Request.Body()` to...

@dojutsu-user maybe you can have a look at changing it so that `Request.Body()` prints a warning using [Server.Logger](https://pkg.go.dev/github.com/valyala/fasthttp#Server.Logger) (so only when used in a server context).

Yeah but keep it private, we don't want to expose that.

There is no way to do this without breaking backwards compatibility. Maybe it would work if next to `RetryIf` we added a `RetryIfErr`. A pull request to try that out...

A pull request would be welcome!

It's hard to say. It could for example be http clients trying to connect to a https endpoint. It could be bots. It could be clients that can't handle certificate.