Erik Dubbelboer

Results 272 comments of Erik Dubbelboer

@shawnps I checked the list against our own datacenter list and there are only 226 ranges that we don't see as datacenter: https://pastebin.com/raw/dj770WF5 The last column in this file is...

https://www.ip2location.com/ has an IPv6 list and classifies ranges as datacenters.

How are you measuring memory usage? If you want to close keep-alive connections you should set a `Connection: close` header in your requests. Or you could set https://godoc.org/github.com/valyala/fasthttp#Client.MaxIdleConnDuration to a...

Sounds like more memory than should be required. But keep in mind that fasthttp trades more memory usage for less CPU usage by reusing buffers. What I would do next...

Would you be willing to share your code in private with me so I can see what can be improved?

I need a lot more information or some way to reproduce what you are seeing.

I haven't tried it but I think you can use any tls package by using [`Client.Dial`](https://pkg.go.dev/github.com/valyala/fasthttp?utm_source=godoc#Client.Dial) to supply your own Dial function using your own tls package. As long as...

I guess there is no way for it to know that it shouldn't wrap the conn in a new `tls.Conn` here: https://github.com/valyala/fasthttp/blob/a5f448fc970972ab47113971d898a22fb28fef52/client.go#L1983-L1989 I would be open to a pull that...

The problem is that after `MaxRequestBodySize` bytes have been received a response is written to the socket and the socket is closed. This makes future writes to the socket fail....

We need better documentation regarding the RequestCtx implementing the Context interface. The channel returned by `RequestCtx.Done()` is only closed [when the server is shutting down](https://github.com/valyala/fasthttp/blob/c94581c0055174e7588b2473dcd3b8a7612500d0/server.go#L2691). And for performance reasons I...