Erik Dubbelboer

Results 293 comments of Erik Dubbelboer
trafficstars

I don't think that will fix it. How about we just reject all requests with `..` on windows?

Do you have a standalone reproducible example? For example the following code works fine: ```go package main import ( "bufio" "fmt" "github.com/valyala/fasthttp" ) func handler(ctx *fasthttp.RequestCtx) { ctx.Response.SetBodyStreamWriter(func(w *bufio.Writer) {...

You mean one returns from the handler and the other doesn't? Both cases should work fine with the code you have now, that's why you have the WaitGroup. I just...

@gilwo I have just pushed some changes to make it work how a net/http handler expects the Hijack method to work. Can you check if this works for you?

Can you show some code to reproduce the issue? It's probably a missing port somewhere as that is the only code that uses Atoi.

There seems to be a linting issue, can you fix that. You said `problematic for very old web servers`, I'm curious which web servers? I understand why the Go team...

There is a bunch of tests failing, can you have a look at that? You can run the tests locally with `go test ./...`.

We already have an exposed function with the same name. I would be open to a pull request to add an option for this to Request.

Sounds like your MaxConnsPerHost is configured to a higher number than what the DSP allows? If keep alive connections are being used properly I wouldn't expect much time spent on...

I don't have time to add this but a pull request is always welcome!