Erik Dubbelboer

Results 307 comments of Erik Dubbelboer

It could make sense but I'm afraid it will be a lot harder to implement correctly than you think. If you can try to make a PR please do.

The problem is that all our methods assume there aren't duplicate cookies. [`RequestHeader.Cookie(key)`](RequestHeader.Cookie) for example returns a single value. Changing that to return multiple values would break backwards compatibility. Adding...

I'm open for a pull request that only changes which of the cookies is returned.

What version are you using? v1.46 contained a fix that might be relevant here: https://github.com/valyala/fasthttp/commit/87cb886157ae414e178fd5bc14a57d5e1c8fcadb

I'm open to a pull request that adds an extra field for this.

If I understand it correctly, what we actually need is a `Client.DialTimeout` and `HostClient.DialTimeout` configuration option that can be used here instead of `return DialTimeout(...`. So users who use a...

I don't think it's because of that change. Both `Dial` and `DialTimeout` use 'TCPDialer.dial`. So they both always required it: https://github.com/valyala/fasthttp/blob/9bc8e480c444fa6bf54a4cd79091692ceff6011c/tcpdialer.go#L189-L216 What did you do before that made the port...

I'm a little bit afraid to make backwards breaking changes like this. I'll leave this pull request open for now and see if anyone else runs into this.

A pull request would be welcome! Or some code to reproduce this so we can easily write a test and fix that.