Erik Dubbelboer

Results 293 comments of Erik Dubbelboer
trafficstars

How are you sending the requests for your benchmark? Can you do some profiling to see what is going on? https://blog.golang.org/2011/06/profiling-go-programs.html

That would be weird as fasthttp should use a lot less goroutines than net/http (1 per connection vs 3 per connection I think). Maybe it was something with GOMAXPROCS, or...

Are we talking about a server handler or a client response?

Sounds like a good idea, a pull request is welcome!

I'm afraid that this sounds like a problem on the client side. If a server sends `Connection: close` the client is supposed to terminate the connection, but the server can't...

The problem is that we currently don't keep a list of connections and the state their are in. I would like to welcome anyone to make a pull request for...

What you did look ok at a glance. Only `stopSendingMessages` needs to be an `atomic.Bool`. The reqs/second is probably limited by the speed of the proxies or your target.

I haven't seen any implementation for that yet. A pull request is always welcome.

Can you make a pull request including a test that fails before and passes after your change?

I think we should just disable FS on windows. It's not safe, it's not properly tested and nobody should be using it in production.