Eric Nielsen

Results 168 comments of Eric Nielsen

Hi, you've got a great set of rules in your plugin! FYI, I see some rules are also implemented in other plugins: * PIE781 and R504 (from https://github.com/afonasev/flake8-return) * PIE791...

The jquery address plugin is not designed to work inside the document ready function. Verify your code. See #119. Also, if you are setting the `state` option, all URLs but...

I got the problem. The form at `http://host.com/#/page/` was ``. Two separate thing were happening: 1. The form was being submited to `http://host.com/page/#anchor`, and prior to call to `$.address.state('\')`, an...

@xqt, your first example could be rewritten as: ``` formatted = _USER_AGENT_FORMATTER.format(format_string, **values) # clean up after any blank components return formatted.replace('()', '').replace(' ', ' ').strip() ``` but I totally...

Actually, maybe someone would want the opposite of R504 to keep a consistent style: "only return a variable (or a constant?), never an expression".

This is how it looks like: ## Before / After ![Screen Shot 2021-02-19 at 20 23 56](https://user-images.githubusercontent.com/4120606/108579499-16ccb300-72f5-11eb-8207-13c40ceb38c1.png)

Hi @scottchiefbaker, sure! Let me rebase it.

Done. The changes depend on eb4a5e7 (Don't include ansi color codes in file1 and file2, from #387), which was merged to master, but not to next (ooops, sorry, I didn't...

@scottchiefbaker, I apologize about the confusion I've made around the fix for the "Use of uninitialized value $less_charset in pattern match" error. I didn't notice it was already fixed in...

Cool. I see d-s-f is already caching the git config output in `$static_config`. But it parses it once for each call of `sub git_config`. So maybe the parsed result can...