Eric Nielsen
Eric Nielsen
@sunaku, PR updated.
It was being spelled as "Control" and "C" and also "^" before. I tried to unify it to a common format ("CONTROL"), as we have other keys in all caps...
Created https://github.com/zsh-users/zsh-history-substring-search/pull/123
Here are some test cases I believe exemplify the possible scenarios, based on the existing test cases: ```python #: Okay import mod.good as nice #: Okay import Mod.good as nice...
Fix should be as simple as ```patch diff --git a/src/pep8ext_naming.py b/src/pep8ext_naming.py index 2755aaa..b2ad238 100644 --- a/src/pep8ext_naming.py +++ b/src/pep8ext_naming.py @@ -396,7 +396,7 @@ class ImportAsCheck(BaseASTCheck): asname = name.asname if not asname:...
Congratulations on your newborn! Don't mind paying attention to this issue at least for the next 3 years or so! :- ) --- Let me try to rephrase the issue....
I see what you mean. `from mod import NICE` allows referring to `NICE` directly, while `import mod.NICE` makes you refer to `mod.NICE`. `from SalesforcePy import common as sfc` works, but...
I think I have a solution that makes more sense, in PEP8 terms, than the discussion I started above (and sorry if that was confusing). Given that > when using...
> The [Package and Module Names section](https://peps.python.org/pep-0008/#package-and-module-names) tells us how a (source) module should be named, but I don't know if we should be adding enforcement to `import`'ing side. Agree....
Cool. Let me work on the code changes and propose then in a PR.