Eric Nielsen

Results 169 comments of Eric Nielsen

I can take care of all PRs and I'm aiming all of them for v3 since each step roughly depends on the previous ones. Just opened a PR for step...

I'm thinking in doing all these in the next PR together: * Add `from __future__ import annotations` to all files, including examples * Enable all ruff `TCH` rules * Enable...

@leandrodamascena, I'd say I'm roughly halfway done with opening the PRs. Let me know if we're in the right path here and I can continue, or if there's any second...

@leandrodamascena for you to have a glimpse on how all the examples changes look like and assess if it's worth it. Most changes here have been automatically done and deserve...

``` ❯ git show | grep '\-from typing import' | wc -l 95 ❯ git show | grep '\+from typing import .*TYPE_CHECKING' | wc -l 292 ``` We're arguably adding...

Oi @leandrodamascena. Totally agree with all your points! Also very good to know the challenges around highlighting.

Oi @leandrodamascena. Sure, I'll be very happy to be able to contribute again!

Oi @jairhenrique. This is still an ongoing issue. Can I get your eyes and approval for a PR that I can submit that fixed this? Valeu!

For reference, here's a sample setup: ```yaml AppSyncOpenSearchCollectionDataSourceRole: Type: AWS::IAM::Role Properties: AssumeRolePolicyDocument: Version: 2012-10-17 Statement: - Effect: Allow Principal: Service: appsync.amazonaws.com Action: sts:AssumeRole Policies: - PolicyName: appsyncopensearchcollectiondatasource PolicyDocument: Version: 2012-10-17...