Eric Nielsen

Hi @scottchiefbaker. I'm loving all the recent optimizations. I've just rebased the PR commit and updated it to hardcode the UTF-8 encodings. Thanks!

@scottchiefbaker, correct: the "commit lines" show up in `git show` and `git log`, but not in `git diff`. The `git diff` only has the "meta lines", for which I'm changing...

@scottchiefbaker, I've updated the PR so the behavior with `git diff` is unchanged (only ruler is drawn around each meta line, like in the [screenshot in the README.md](https://github.com/so-fancy/diff-so-fancy/blob/566d951e23a3307fb117b8bbc6c379fbc3b351ce/README.md#screenshot)). For `git...

Hi @scottchiefbaker. Anything I can still do in this PR for you to reconsider it? I'm refactoring some of the current code here, and at the end the change only...

Hi @scottchiefbaker. Sure, votes from the core developers sounds good to me. Please all note that the changes I'm proposing here don't affect the output of `git diff` in any...

I have a suggestion for this in https://github.com/so-fancy/diff-so-fancy/pull/398

Maybe the solution is to have two separate converters: one for the old attribute names, and one for the new ones. ```python import json import attr from cattr.gen import make_dict_structure_fn,...

And @TomGoBravo, for nested attributes, which I'm assuming come from a composition of objects of different classes, you can register converter hooks for each separate class: ```python import json import...

Shouldn't we encourage users to export the `DIRENV_LOG_FORMAT` just in their `.bashrc`, `.zshrc`, etc. file instead of in `direnvrc`? Setting it in `direnvrc` has the issue raised here, plus it...

When using `make_dict_unstructure_fn`/`make_dict_structure_fn` it becomes even more verbose. So I usually just create a function like: ```python def converter_register_hooks(cls, **kwargs): converter.register_unstructure_hook(cls, make_dict_unstructure_fn(cls, converter, **kwargs)) converter.register_structure_hook(cls, make_dict_structure_fn(cls, converter, **kwargs)) ``` And...