Sebastian "Sebbie" Silbermann
Sebastian "Sebbie" Silbermann
> Happy to consider removing it if y'all are noticing it running ok in your fork and once i've had a chance to resurface from I/O craziness. Will do. We...
> the polyfill no longer works as desired @joshuaruesweg Could you elaborate in what circumstances which expected behavior did not occur?
Libraries reading from `children.props` should resolve defaultProps themselves via `const childProps = { ...child.type.defaultProps, ...child.props}`
This is intentional behavior. If you want to handle the error locally, use `try-catch`. Otherwise handled it in the nearest error boundary. For docs, please open an issue in https://github.com/reactjs/react.dev
I'll check out what's wrong here
Thank you for the minimal repro!
As far as I can tell, this usage is sound. It's just that [TypeScript (with `noUncheckedIndexAccess`)](https://www.typescriptlang.org/play/?strict=false&noUncheckedIndexedAccess=true&jsx=4&exactOptionalPropertyTypes=false#code/OQVwzgpgBAxgNgSwgOwC7AFAILYAcD2ATqlAN5TgQDCAhnHAEY0wDWANBZAMqo2rQBfKADNC+bFABEhCM1SSMGCAA8CxKABMIwmiDglhIZDFQJ8yKAAUaAcwgAKcpUJgOzgJIaoAgFxlOEC5+AEoQMEQaADxgqIQIyDYc5Mg02BB+MXEJ3gB8bpCEnhmx8TbeAJRkGFCw5jEBhFAAvA1gANoeGgC6ijXhyPVw+DYAqgXNAbT0TKz29pVNOVU1fXX4cBAAdEM29sAAMsMNwPmBmylp5dXeHB0FXVe9UDKoIIQW9tc1kRoIAG45L4rSIACwAjDlrHZIgB6cGAlYrUjOKAAfign0RiJ+-wRWOxIIATDlkQVzqkIAJYUS8fjvgwQKhUOYoOYqIhWE1SPNmktSEC6bUBustjs9ocys4Tg1yZcBViBAIchL8IzYQymeZaVjYb8AfLKn5kHo4AIgbrcdcrgIgA) and [Flow.js as well](https://flow.org/try/#1N4Igxg9gdgZglgcxALlAIwIZoKYBsD6uEEAztvhgE6UYCe+JADpdhgCYowa5kA0I2KAFcAtiRQAXSkOz9sADwxgJ+NPTbYuQ3BMnTZA+Y2yU4IwRO4A6SFBIrGVDGM7c+h46fNRLuKxJIGWh8MeT0ZfhYlCStpHzNsFBAMIQkIEQwJODAQfiEyfBE4eWw2fDgofDBMsAALfAA3KjgsXGxxZC4eAw0G-GhcWn9aY3wWZldu-g1mbGqJUoBaCRHEzrcDEgBrbAk62kXhXFxJ923d-cPRHEpTgyEoMDaqZdW7vKgoOfaSKgOKpqmDA+d4gB5fMA-P6LCCMLLQbiLOoYCqgh6-GDYRYIXYLSgkRZkCR4jpddwPfJLZjpOBkO4AX34kA0STMjAglAkAAJgFzKQBhbi4TBgLa8PlkADKlgWXPpXJglHSXIAOiAoso1QBuFVQXUKdmcrkaLQ6BUPZRwaBcgAKGBxAApgLquRKTCReC63ZQAJJsT1QenIHleyn44O8gDa9lMUAQAF0I1yoM5sMGYxUEHKuQAfPlQE0VUpygOusN+9NSTMB+kAShDUFdtns3q5AF5vSRI+W2PGdXrG1zm9yiAgAKpkSjtt2C44irYOh31tsAPgbrqb0BIEDaVlHDrVABkIFmw2rxWGrCnzLX+67GVzu5P47fdV6WBIhJRGwfB66ADxsHADQrl6G5cv+tQAIwrnaOL-gA9NBoF-huwBhlyAD8XK-uB4GAcBKF4XhADzkEAEwruhk5Xqm9KIbUlFgcREFoKkaQDixeHQPyuDZFsbbAEu7Zrs6qFcZudg7tge4ngeIDHqek7nt6tE3neEn3vSzHEURmlcopECpDpeGIWxxLQHpxGIUBIEmfWwZHLg2moTZhFeq+ga6rkIANO6VpQEkDQAAxWORADMABsVjBSA9JAA), don't realize that `logUser` is used in a scope where...
Just need to bring this up internally so that we're aligned on prop naming. If anybody wants to test it out, you can install ```bash react@https://react-builds.vercel.app/api/prs/27981/packages/react react-dom@https://react-builds.vercel.app/api/prs/27981/packages/react-dom ``` to test...
That was not our impression when testing. What else is broken in your opinion?
Libraries should work on compat before a new major is released. Otherwise early adoption by app devs is not possible if they use any library.