Sebastian "Sebbie" Silbermann

Results 555 comments of Sebastian "Sebbie" Silbermann

> We are testing recharts with react 19 beta in production, everything works fine except for recharts. Are you using a build from this PR?

> Will review and get this merged/released once marked ready/tests are passing @ckifer Ready for review. Will fix tests as CI reveals them but you've configured your repo to block...

I file a separate PR targetting 3.x. I won't test the 3.x version on React 19 though.

Forward port for 3.x: https://github.com/recharts/recharts/pull/4561

> Imo warrants some more testing though, I might release with an alpha tag That'd be nice. We'll land the patch in prod start of next week too. Would appreciate...

> Breaks about 80 unit tests when ran with React 19. Good thing is that R18 and below is fine... but we'll need all these to pass to release this...

@tounsoo Keep in mind that `anchor-name` must be a [dashed ident](https://developer.mozilla.org/en-US/docs/Web/CSS/dashed-ident). Though it still doesn't work when prefixed with `--`

Fixed with https://github.com/facebook/react/pull/32001

It may or may not work as expected. I think for this one there wasn't any specific implementation work required but still. That's why React 17 will warn if you...

Simplified repro: https://codesandbox.io/p/sandbox/magical-oskar-8gnqgd?file=%2Fsrc%2Findex.js%3A23%2C60 @souporserious Can you check if the same happens with `renderToString` and `renderToPipeableStream`?