Sebastian "Sebbie" Silbermann

Results 555 comments of Sebastian "Sebbie" Silbermann

Some feedback regarding defaultProps deprecation after [migrating around 90 components away from defaultProps](https://github.com/mui-org/material-ui/pull/15473): 1. bundle size went up (+0.05% parsed, +0.50% gzipped). IE11 and chrome 45 don't support object destructuring...

> Can you elaborate on the types of patterns that you'd expect to be supported but aren't? ```js // A // default value of `foo` recognized function Component({ foo =...

How I understood this is that you are then computing the text alternative of the button without being in the context of a label of another element. So while I...

> If I am not mistaken, the AccName does not currently clearly regulate whether two adjacent nodes are output with or without spaces. I think it's only unclear in 2.F.iii:...

@JAWS-test So you're saying 2E needs a section explaining 1. what is a "control" 2. what happens with elements that are not explicitly listed in that step (i.e. which elements...

It does now include `listbox`: > If the embedded control has role combobox or listbox, return the text alternative of the chosen option. But the point remains about `aria-multiselectable`. I...

We decided against a codemdoddable warning

The plan is to land unfreezing `this.refs` for 18.3 and 19. Then we can use this codemod.

> Can you make the Strict Mode text clickable in the new updated label? ![Screenshot 2024-05-20 at 23 32 20](https://github.com/facebook/react/assets/12292047/2ce01c9b-9a19-4a61-929a-9fc4fd19a4f5) > Also, could you please update function names [here](https://github.com/facebook/react/blob/main/packages/react-devtools-shared/src/hook.js?rgh-link-date=2024-05-20T17%3A23%3A03Z#L228) to...

If you want to opt-out of automatic form reset, you should continue using `onSubmit` like so: ```diff +function handleSubmit(event) { + event.preventDefault(); + const formData = new FormData(event.target); + startTransition(()...