react icon indicating copy to clipboard operation
react copied to clipboard

[Flight] Add failing test to reproduce issue with `Object.freeze`

Open unstubbable opened this issue 1 month ago • 3 comments

Here's a failing test that demonstrates the issue as reported by @eps1lon in https://github.com/facebook/react/pull/29032#discussion_r1604250460.

https://github.com/facebook/react/blob/3f1436cca1f8dd80a19fd52b97b6ff71a4d9ce82/packages/react-client/src/ReactFlightClient.js#L644

When the props object is frozen, the Flight Client's model resolver can't mutate the parent object (i.e. the props) anymore, after the client component that was referenced in the props has been loaded.

https://github.com/facebook/react/blob/3f1436cca1f8dd80a19fd52b97b6ff71a4d9ce82/packages/react-client/src/ReactFlightClient.js#L701

unstubbable avatar May 17 '24 08:05 unstubbable